r208345 - Remove -Wnon-modular-include

[Argyrios Kyrtzidis]

On May 9, 2014, at 12:05 AM, Alp Toker <alp at nuanti.com> wrote:

> 
> On 09/05/2014 07:34, Argyrios Kyrtzidis wrote:
>> Hmm, there is a difference between a warning that is designed to find problems but ends up too noisy in practice and a "remark"
> 
> ... and a remark is also a noisy warning designed to find problems.
> 
>> , we should not conflate the two concepts.
> 
> The two are the same thing.

Let me give you a specific example:
We recently introduced -Wmodule-build to "make it easy to see when modules are (re)built". Do you regard this as designed to find problems ?

Now consider that people have the workflow of having -Weverything, so that when clang introduces a new warning they can see it, be aware of it, and see if it finds new problems in their code.
What is the value for these people to get a brand new compiler, compile their code and see "warning: building module 'Foundation' as '/path/to/Foundation.pcm'" ?

> 
> (Whether they get treated as remarks, warnings or errors should be a question of mapping only.)
> 
> Alp.
> 
> -- 
> http://www.nuanti.com
> the browser experts
>