[PATCH] Permit duplicate explicit class instantiations if MSVCCompat is enabled

[Reid Kleckner]

Seems consistent with what MSVC does.

I'd change the wording of the warning to match our other extension
warnings.  Something like: "... (is|are|as) a Microsoft extension"

Otherwise, looks good.


On Wed, May 7, 2014 at 9:58 AM, Will Wilson <will at indefiant.com> wrote:

> Now with added patch...
>
>
> On 7 May 2014 18:57, Will Wilson <will at indefiant.com> wrote:
>
>> Hi All,
>>
>> Here's a small patch to allow duplicate explicit class instantiations
>> through with only a warning in MSVCCompat mode. MSVC itself silently
>> ignores duplicate explicit instantiations. Clang appears to skip any
>> duplicates so it shouldn't be too much of an issue to reduce the error to a
>> warning for MSVC compatibility in this case.
>>
>> Test case included and clang format applied. Let me know if it LGTY.
>>
>> Cheers,
>> Will.
>>
>
>
>
> --
> *Indefiant *: http://www.indefiant.com
> Home of Recode : Runtime C++ Editing for VS
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140508/3b7b7c29/attachment.html>