r208258 - CodeGen: Don't set hidden visibility on symbols with local linkage

[Justin Bogner]

"Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
> --- cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp (original)
> +++ cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp Wed May  7 17:36:11 2014
> @@ -1586,7 +1586,8 @@ ItaniumCXXABI::getOrCreateThreadLocalWra
>                  CGM.getLLVMLinkageVarDefinition(VD, /*isConstant=*/false)),
>        WrapperName.str(), &CGM.getModule());
>    // Always resolve references to the wrapper at link time.
> -  Wrapper->setVisibility(llvm::GlobalValue::HiddenVisibility);
> +  if (!Wrapper->hasLocalLinkage())
> +    Wrapper->setVisibility(llvm::GlobalValue::HiddenVisibility);
>    return Wrapper;
>  }

Does the comment here need updating?