r207011 - Quick fix for layering that broke shared library build.
Thompson, John
John_Thompson at playstation.sony.com
Wed May 7 17:19:09 PDT 2014
>+ if ((Mode == CTK_ErrorRecovery) && getLangOpts().Modules &&
>+ getLangOpts().ModulesSearchAll) {
>+ if (PP.getModuleLoader().lookupMissingImports(Typo->getName(),
>+ TypoName.getLocStart())) {
>+ TypoCorrection TC(TypoName.getName(), (NestedNameSpecifier *)0, 0);
>+ TC.setCorrectionRange(SS, TypoName);
>+ TC.setRequiresImport(true);
>
>This TC variable is unused; remove it?
>
>I suspect TC was intended to be added to Consumer so that it participates in typo correction as a candidate... John, is that a correct >assumption? If not then this block of code does nothing beyond whatever side effects .lookupMissingImports() may have, and the >TC variable should be removed.
Thanks for finding this! Fixed in r208259.
-John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140508/7ed36315/attachment.html>
More information about the cfe-commits
mailing list