[PATCH] Enable standalone-debug by default on FreeBSD

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed May 7 10:48:59 PDT 2014


Can you add a testcase?

On 7 May 2014 13:36, Ed Maste <emaste at freebsd.org> wrote:
> It was set by default on Darwin in r198655.  The same usability issues
> with DTrace and LLDB apply to FreeBSD, so set it by default there too.
>
> rdar://problem/15758808
> http://llvm.org/pr19676
>
> http://reviews.llvm.org/D3654
>
> Files:
>   lib/Frontend/CompilerInvocation.cpp
>
> Index: lib/Frontend/CompilerInvocation.cpp
> ===================================================================
> --- lib/Frontend/CompilerInvocation.cpp
> +++ lib/Frontend/CompilerInvocation.cpp
> @@ -325,9 +325,10 @@
>    } else if (Args.hasArg(OPT_g_Flag) || Args.hasArg(OPT_gdwarf_2) ||
>               Args.hasArg(OPT_gdwarf_3) || Args.hasArg(OPT_gdwarf_4)) {
>      bool Default = false;
> -    // Until dtrace (via CTF) can deal with distributed debug info,
> -    // Darwin defaults to standalone/full debug info.
> -    if (llvm::Triple(TargetOpts.Triple).isOSDarwin())
> +    // Until dtrace (via CTF) and LLDB can deal with distributed debug info,
> +    // Darwin and FreeBSD default to standalone/full debug info.
> +    if (llvm::Triple(TargetOpts.Triple).isOSDarwin() ||
> +        llvm::Triple(TargetOpts.Triple).isOSFreeBSD())
>        Default = true;
>
>      if (Args.hasFlag(OPT_fstandalone_debug, OPT_fno_standalone_debug, Default))
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list