[PATCH] Pragma optimize on/off

[Dario Domizioli]

Thanks Aaron!

Patch LGTM, modulo Richard's comments about serialization (I worried
> about the same thing, and my preference is for the patch to be
> all-inclusive when feasible, but Richard is welcome to weigh in). I
> have no strong opinions on whether it should be one diagnostic or two.
>

I will wait for Richard's comments then; meanwhile I'll keep working on the
serialization issue.

As for the diagnostics, I think that having two might make it easier to
extend the "unexpected" case if the pragma gains new functionality in the
future, while the "missing" case is unlikely to change... although the
%select is quite powerful so I haven't got a strong preference either.

Cheers,
    Dario Domizioli
    SN Systems - Sony Computer Entertainment Group
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140507/fa49df8d/attachment.html>