r208128 - Include translation unit filename in global ctor symbol names.

Alexey Samsonov samsonov at google.com
Tue May 6 16:54:58 PDT 2014


On Tue, May 6, 2014 at 4:49 PM, Reid Kleckner <rnk at google.com> wrote:

> On Tue, May 6, 2014 at 3:39 PM, Alexey Samsonov <samsonov at google.com>wrote:
>
>> Correct, _GLOBAL__I_a is hardcoded in ASan instrumentation pass. I'm not
>> opposed to the change, just curious - what
>> parts of ASan reports would you like to improve? Generally, there's at
>> least __cxx_global_var_initN function in the report, which
>> has the correct file name in the debug info.
>>
>
> There was a user that accidentally built with -g0, and the
> __cxx_global_var_initN function got inlined away.  We don't really have to
> support users of -g0, of course, but if it would've been useful to two
> people, what the heck, let's mangle in the basename.
>

Sure, let's do it :)

-- 
Alexey Samsonov, Mountain View, CA
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140506/65294137/attachment.html>


More information about the cfe-commits mailing list