[PATCH] AST: Update reference temporary mangling

Richard Smith richard at metafoo.co.uk
Tue May 6 14:41:19 PDT 2014


================
Comment at: lib/AST/ItaniumMangle.cpp:3433
@@ +3432,3 @@
+
+      char c = static_cast<char>(SeqID % 36);
+
----------------
Since you're moving this code anyway... why the `static_cast`? Also, `C` not `c`. Also, using a `char` here is a little weird. :)

http://reviews.llvm.org/D3631






More information about the cfe-commits mailing list