Support for Amazon Linux

[Hal Finkel]

----- Original Message -----
> From: "Rafael Espíndola" <rafael.espindola at gmail.com>
> To: "Dave Johansen" <davejohansen at gmail.com>
> Cc: "llvm cfe" <cfe-commits at cs.uiuc.edu>
> Sent: Tuesday, May 6, 2014 11:25:57 AM
> Subject: Re: Support for Amazon Linux
> 
> On 25 April 2014 11:03, Dave Johansen <davejohansen at gmail.com> wrote:
> > I opened a Bugzilla requesting that support for Amazon Linux be
> > added (
> > http://llvm.org/bugs/show_bug.cgi?id=19550 ). I've attached the
> > patch for
> > 3.4 and 3.5 that add the appropriate triple values for Amazon
> > Linux.
> 
> We normally make sure the change is in trunk and then backport, so
> commenting only on the 3.5 change:
> 
> Can you add a testcase? Under clang/test/Driver/Inputs/ you will find
> some fake directory layouts, you should be able to add one for amazon
> linux and add a test that uses it.

Unfortunately, I don't think that these are currently testable because the sysroot is not respected by DetectDistro:

  if (!llvm::MemoryBuffer::getFile("/etc/redhat-release", File)) {
    StringRef Data = File.get()->getBuffer();
    if (Data.startswith("Fedora release"))
      return Fedora;
    else if (Data.startswith("Red Hat Enterprise Linux") &&
             Data.find("release 6") != StringRef::npos)
      return RHEL6;
...

We'd need to change that first, no?

 -Hal

> 
> Cheers,
> Rafael
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory