[PATCH] Add -Wnon-modular-include options

[Richard Smith]

Sorry for the delay!

Can you factor out the known header checking, or move it into an 'if',
rather than skipping it with a goto?

Otherwise, LGTM, thanks!


On Sun, May 4, 2014 at 7:07 PM, Ben Langmuir <blangmuir at apple.com> wrote:

> gentle ping
>
> On Apr 28, 2014, at 8:54 PM, Ben Langmuir <blangmuir at apple.com> wrote:
>
> > This patch adds the warning options:
> >
> > -Wnon-modular-include -- warn on any #include of a header that's not
> listed in a module map
> >  [-Wnon-modular-include-in-module -- subgroup, only warn if the include
> is in a module]
> >    -Wnon-modular-include-in-framework-module -- subgroup, only warn if
> the include is in a framework module
> >
> > There had been discussion of this making -fmodules-strict-decluse
> redundant, but I wasn’t sure if we came to an agreement about that, so I
> didn’t remove it.
> >
> >
> > Ben<non-modular-include.patch>
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140505/8f9dc38c/attachment.html>