[PATCH] Some heuristics to identify c style casting (PR18937)

Dinesh Dwivedi dinesh.d at samsung.com
Mon May 5 06:06:17 PDT 2014


================
Comment at: lib/Format/TokenAnnotator.cpp:794
@@ +793,3 @@
+          } else {
+            // Use heuristics to recognize c style casting
+            FormatToken *Prev = Current.Previous;
----------------
Daniel Jasper wrote:
> nit: Period at the end of a sentence.
updated

================
Comment at: lib/Format/TokenAnnotator.cpp:807
@@ +806,3 @@
+
+            for (; Prev != Current.MatchingParen; Prev = Prev->Previous)
+              if (!Prev || !Prev->isOneOf(tok::kw_const, tok::identifier)) {
----------------
Daniel Jasper wrote:
> nit: I'd prefer {} here..
updated

http://reviews.llvm.org/D3576






More information about the cfe-commits mailing list