r207833 - XCore target: fix handling of -g0 flag

[Reid Kleckner]

On Fri, May 2, 2014 at 11:04 AM, David Blaikie <dblaikie at gmail.com> wrote:

> On Fri, May 2, 2014 at 8:33 AM, Robert Lytton <robert at xmos.com> wrote:
> > Hi David,
> >
> > The patch is to the XCore::Assemble::ConstructJob() method.
> > The OPT_g_Group flags are all forwarded to the external xcore assembler
> as a
> > '-g' flag,  apart from '-g0',  hence the fix.
> > Other assemblers may require different flags as directed by their
> > Assemble::ConstructJob() specialization.
> >
> > Does this answer your question?
>
> Somewhat - a quick survey shows that there's a similar bug in darwin
> and visualstudio support... not sure if there's a nicer way to handle
> this so we don't have to refix the bug everywhere.


We're already hosed if we try to invoke an external assembler in VS land.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140502/da789d06/attachment.html>