r207573 - scanf analysis: handle scanlists that start with ^] (PR19559)

Hans Wennborg hans at chromium.org
Fri May 2 11:20:04 PDT 2014


On Fri, May 2, 2014 at 10:59 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> Hi Hans,
>
> Drive-by review...
>
> On Tue, Apr 29, 2014 at 9:42 PM, Hans Wennborg <hans at hanshq.net> wrote:
>>
>> +  // Special case: "]^" are the first characters.
>> +  if (I + 1 != E && I[0] == '^' && I[1] == ']') {
>
> The comment says "]^" but the code is looking for "^]" -- I'm guessing
> the code is right?

Yup :) Thanks for spotting this! Fixed in r207854.

Cheers,
Hans




More information about the cfe-commits mailing list