[PATCH] Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599).

[David Blaikie]

On Wed, Apr 30, 2014 at 10:17 AM, Manuel Klimek <klimek at google.com> wrote:
> On Wed, Apr 30, 2014 at 6:03 PM, Alex McCarthy <alexmc at google.com> wrote:
>>
>> Thanks, I'll do that next time. Should I use that instead of git svn
>> dcommit to push the change?
>
>
> I usually just commit with git svn dcommit (I find the commit message from
> arc commit a bit too wordy for my taste).

Could we get that fixed?

Just taking Alexey's recent commit:

"Summary: No functionality change.

Test Plan: llvm regression test suite.

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: echristo, llvm-commits"

All seems fairly unnecessary - except maybe the "Reviewed By" field.
(it'd be nice to phrase that as "Approved By" to make it clear that
there was actual sign off)

>
>>
>> -Alex
>>
>>
>> On Wed, Apr 30, 2014 at 7:58 AM, Alexander Kornienko <alexfh at google.com>
>> wrote:
>>>
>>> On Wed, Apr 30, 2014 at 4:26 PM, Alex McCarthy <alexmc at google.com> wrote:
>>>>
>>>> ================
>>>> Comment at: test/clang-tidy/temporaries.cpp:3
>>>> @@ +2,3 @@
>>>> +// FileCheck complains if the input file is empty, so add a dummy line.
>>>> +// RUN: echo foo >> %t.log
>>>> +// RUN: FileCheck %s < %t.log
>>>> ----------------
>>>> Alexander Kornienko wrote:
>>>> > You don't need this now as the correct output is guaranteed to be
>>>> > non-empty. And you can now just pipe clang-tidy output to FileCheck
>>>> Good catch: fixed in llvm-reviews.chandlerc.com/rL207653
>>>>
>>>> http://reviews.llvm.org/D3556
>>>>
>>>
>>> BTW, if you use Phabricator's arc tool, you can also use "arc commit",
>>> which automatically closes the Differential revision in Phab.
>>
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>