[PATCH] Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599).

[Alexander Kornienko]

On Wed, Apr 30, 2014 at 6:03 PM, Alex McCarthy <alexmc at google.com> wrote:

> Thanks, I'll do that next time. Should I use that instead of git svn
> dcommit to push the change?
>

I use it with svn, and it works well. But I don't know how well it works
with git-svn (or whatever you use to get llvm repository in git). If it
doesn't, you don't need to die trying, obviously ;)


>
> -Alex
>
>
> On Wed, Apr 30, 2014 at 7:58 AM, Alexander Kornienko <alexfh at google.com>wrote:
>
>> On Wed, Apr 30, 2014 at 4:26 PM, Alex McCarthy <alexmc at google.com> wrote:
>>
>>> ================
>>> Comment at: test/clang-tidy/temporaries.cpp:3
>>> @@ +2,3 @@
>>> +// FileCheck complains if the input file is empty, so add a dummy line.
>>> +// RUN: echo foo >> %t.log
>>> +// RUN: FileCheck %s < %t.log
>>> ----------------
>>> Alexander Kornienko wrote:
>>> > You don't need this now as the correct output is guaranteed to be
>>> non-empty. And you can now just pipe clang-tidy output to FileCheck
>>> Good catch: fixed in llvm-reviews.chandlerc.com/rL207653
>>>
>>> http://reviews.llvm.org/D3556
>>>
>>>
>> BTW, if you use Phabricator's arc tool, you can also use "arc commit",
>> which automatically closes the Differential revision in Phab.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140430/53a6afeb/attachment.html>