r207521 - Add comments regarding isPIEDefault usage for r207520

Alexey Volkov avolkov.intel at gmail.com
Tue Apr 29 05:07:35 PDT 2014


Author: volkalex
Date: Tue Apr 29 07:07:34 2014
New Revision: 207521

URL: http://llvm.org/viewvc/llvm-project?rev=207521&view=rev
Log:
Add comments regarding isPIEDefault usage for r207520

Differential Revision: http://reviews.llvm.org/D2668

Modified:
    cfe/trunk/lib/Driver/Tools.cpp

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207521&r1=207520&r2=207521&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Tue Apr 29 07:07:34 2014
@@ -6920,6 +6920,8 @@ void gnutools::Link::ConstructJob(Compil
     !Args.hasArg(options::OPT_static) &&
     (Args.hasArg(options::OPT_pie) || ToolChain.isPIEDefault() ||
      // On Android every code is PIC so every executable is PIE
+     // Cannot use isPIEDefault here since otherwise
+     // PIE only logic will be enabled during compilation
      isAndroid);
 
   ArgStringList CmdArgs;





More information about the cfe-commits mailing list