[libcxxabi][PATCH] use return address register from CIE

Nick Kledzik kledzik at apple.com
Mon Apr 28 16:53:04 PDT 2014


On Apr 26, 2014, at 1:23 PM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:

> On Thu, Apr 24, 2014 at 06:55:06PM -0700, Nick Kledzik wrote:
>> I got a bug report that the unwinder is not using the
>> return_address_register value in the CIE.  This patch fixes that.
> 
> I had this feature on my TODO list, thanks for doing it. One obvious
> question is the size of the return register field. The highest value
> used on the architectures I have supported in NetBSD is ARM with 128.
> Any reason for not limitting it to uint8_t and putting it near the end
> with the bool fields?
Done in r207467.  I added an assert to validate the return register 
number fits in a uint8_t.

-Nick




More information about the cfe-commits mailing list