[PATCH] Fix bug in clang-format while merging short function (PR19461)

Dinesh Dwivedi dinesh.d at samsung.com
Mon Apr 28 11:17:11 PDT 2014


Updated as per review comments.

I have moved 'I[1]->First->MustBreakBefore' check to line 535. I agree that this is good as there are other check for I[1] but this check is actually required in context at for block of lines 554:570. For lines between 535:554, it is redundant check as this condition is already being checked in tryMergeSimpleBlock().

http://reviews.llvm.org/D3439

Files:
  lib/Format/Format.cpp
  unittests/Format/FormatTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3439.8891.patch
Type: text/x-patch
Size: 4755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140428/e4cd1566/attachment.bin>


More information about the cfe-commits mailing list