r207319 - libclang: remove 'CXDiagnostic_Remark'

[Tobias Grosser]

On 28/04/2014 10:16, Alp Toker wrote:
>
> On 28/04/2014 09:06, Tobias Grosser wrote:
>> On 26/04/2014 16:43, Alp Toker wrote:
>>> Author: alp
>>> Date: Sat Apr 26 09:43:53 2014
>>> New Revision: 207319
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=207319&view=rev
>>> Log:
>>> libclang: remove 'CXDiagnostic_Remark'
>>>
>>> The change was landed without review or test cases.
>>
>> Hi Alp,
>>
>> thanks for getting back to this. At the time of commit I interpreted
>> your OK wrongly
>
> :-)
>
>> and for some unexplainable reason I never came back to your email. I
>> would have prefered a quick ping instead of just reverting this, but
>> as I missed to reply to your original mail the error is fully on my side.
>
> The libclang revert was strictly necessary so I don't think there was
> any other outcome to that.
>
> For what it's worth I've left everything else from your work in-tree
> because other patches had already built up around it. We should still
> try to adapt it towards the simpler approach I suggested when we get time.

I do not yet see the backward compatibility issues and do also not 
understand your proposed solution. Let's try to sort this out in the 
patch review.

>> I already started to address your previously listed concerns (see the
>> VerifyDiagnosticConsumer patch) and will repost this patch to discuss
>> the backward compatibility issues you see.
>
> Great, I'll review this unless someone gets around to it sooner. This is
> very good to have

Thanks.

Tobias