r207203 - CodeGen: Avoid instrumenting implicit Decls more effectively

Duncan P. N. Exon Smith dexonsmith at apple.com
Sun Apr 27 20:04:48 PDT 2014


On 2014 Apr 25, at 00:20, Justin Bogner <mail at justinbogner.com> wrote:

> @@ -803,7 +803,7 @@ void CodeGenPGO::assignRegionCounters(co
>   llvm::IndexedInstrProfReader *PGOReader = CGM.getPGOReader();
>   if (!InstrumentRegions && !PGOReader)
>     return;
> -  if (!D)
> +  if (D->isImplicit())
>     return;

If `D` is never `nullptr`, should it be passed by reference instead?



More information about the cfe-commits mailing list