[PATCH] Windows ToolChain: remove excessive backslash if we find WindowsSDK

Reid Kleckner rnk at google.com
Tue Apr 22 17:24:28 PDT 2014


Thanks for the info, this should be fixed in r206933.

BTW, I recommend not relying on that registry searching code. It's not well
maintained. The best way to make sure you're getting the right VC and SDK
headers is to set INCLUDE in the environment, most likely with
vcvarsall.bat.


On Tue, Apr 22, 2014 at 8:41 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

>
>   I 'm not sure the problem is here. The sys::path::append function knows
> how to deal with duplicate slashes so if you do get duplicate backslash,
> plain string concatenation was probably used instead of sys::path::append.
> In such case the correct bug fix would be to use sys::path::append instead
> of the string concatenation.
>
> http://reviews.llvm.org/D3440
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140422/dbf91b69/attachment.html>


More information about the cfe-commits mailing list