[PATCH] Unify handling guard variables in the Itanium C++ ABI

[Reid Kleckner]

Looks good.


On Tue, Apr 22, 2014 at 9:57 AM, Justin Bogner <mail at justinbogner.com>wrote:

> We previously treated ARM separately from the generic Itanium ABI for
> initializing guard variables.  This code duplication led to things like
> the ARM path missing the memory barrier for threadsafe handling, and a
> highly misleading comment about how we were (mis)using the generic ABI
> for ARM64 when really it went through the ARM codepath.
>
> This unifies the two code paths.  Functionally, this changes the ARM and
> ARM64 codepath to use one byte loads instead of 4 and 8, respectively,
> and adds the missing atomic acquire to these loads.  Other architectures
> are unchanged.
>
> Okay to commit?
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140422/1db449b9/attachment.html>