[PATCH] Allow overriding flag names in diagnostics.

[Diego Novillo]

On Mon, Apr 21, 2014 at 8:09 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 22/04/2014 00:31, Alp Toker wrote:
>
>> I'm not really opposed to the idea, though. I just found the current
>>> version easier to use.
>>>
>>
>> I recommend not modifying the Diag() signature because the feature will
>> be unavailable to other modules until they each update their own Diag()
>> signatures introducing latent churn.
>>
>
> To be clear, my concern is that other developers will propagate this over
> time to other Diag() functions as they would have to to be able to use it
> -- a problem that a fluent extension to DiagnosticBuilder wouldn't suffer
> from.
>

No problem. I don't really care what it uses, as long as I can get the
behaviour I want from the system.  I'll change it to use a manipulator, as
you folks agreed downthread.  Patch coming up.


Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140422/b7690b20/attachment.html>