r206882 - Comment parsing: in the generated XML file, mark HTML that is safe to pass

Alp Toker alp at nuanti.com
Tue Apr 22 04:45:56 PDT 2014


On 22/04/2014 11:59, Dmitri Gribenko wrote:
> +// The list is intentionally organized as one item per line to make it easier
> +// to compare with the HTML spec.
> +foreach AttrName = [
> +    "onabort",
> +    "onblur",
> +    "oncancel",
> +    "oncanplay",
> +    "oncanplaythrough",
> +    "onchange",
> +    "onclick",
> +    "onclose",
> +    "oncuechange",
> +    "ondblclick",
> +    "ondrag",
> +    "ondragend",
> +    "ondragenter",
> +    "ondragexit",
> +    "ondragleave",
> +    "ondragover",
> +    "ondragstart",
> +    "ondrop",
> +    "ondurationchange",
> +    "onemptied",
> +    "onended",
> +    "onerror",
> +    "onfocus",
> +    "oninput",
> +    "oninvalid",
> +    "onkeydown",
> +    "onkeypress",
> +    "onkeyup",
> +    "onload",
> +    "onloadeddata",
> +    "onloadedmetadata",
> +    "onloadstart",
> +    "onmousedown",
> +    "onmouseenter",
> +    "onmouseleave",
> +    "onmousemove",
> +    "onmouseout",
> +    "onmouseover",
> +    "onmouseup",
> +    "onmousewheel",
> +    "onpause",
> +    "onplay",
> +    "onplaying",
> +    "onprogress",
> +    "onratechange",
> +    "onreset",
> +    "onresize",
> +    "onscroll",
> +    "onseeked",
> +    "onseeking",
> +    "onselect",
> +    "onshow",
> +    "onstalled",
> +    "onsubmit",
> +    "onsuspend",
> +    "ontimeupdate",
> +    "ontoggle",
> +    "onvolumechange",
> +    "onwaiting"
> +  ] in {
> +  def Attr#AttrName : EventHandlerContentAttribute<AttrName>;
> +}

Hi Dmitri,

I've been meaning to bring this up earlier but I really don't think this 
kind of functionality belongs in the core of the clang AST/Basic.

We often ask contributors to add even useful features like warnings and 
checks to clang-tools-extra or third-party plugins where it might keep 
things trim. So it's surprising to me that at the same time there's a 
full-featured HTML5 generator and XML parser/tree being incrementally 
hard-coded into clang/AST.

Not sure what others have been making of this..

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list