[PATCH] Allow overriding flag names in diagnostics.

Diego Novillo dnovillo at google.com
Mon Apr 21 16:03:42 PDT 2014


  Instead of an override, provide a flag value.

  As we discussed offline, it seems cleaner to offer callers to provide
  an additional value to the option, instead of overriding it completely.

  This changes the patch so that callers provide an additional value to
  the diagnostic. This value is emitted as the suffix "=value" when
  displaying the flag name.

Hi rsmith,

http://reviews.llvm.org/D3441

CHANGE SINCE LAST DIFF
  http://reviews.llvm.org/D3441?vs=8703&id=8707#toc

Files:
  include/clang/Basic/Diagnostic.h
  lib/CodeGen/CodeGenAction.cpp
  lib/Frontend/TextDiagnosticPrinter.cpp
  test/Frontend/optimization-remark.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3441.2.patch
Type: text/x-patch
Size: 4284 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140421/acd3c4b3/attachment.bin>


More information about the cfe-commits mailing list