[PATCH] Add new 'let' command to bind arbitrary values into constants.

Samuel Benzaquen sbenza at google.com
Mon Apr 21 09:18:14 PDT 2014



================
Comment at: unittests/clang-query/QueryParserTest.cpp:123
@@ +122,3 @@
+  ASSERT_TRUE(isa<InvalidQuery>(Q));
+  EXPECT_EQ("expected variable name", cast<InvalidQuery>(Q)->ErrStr);
+}
----------------
Peter Collingbourne wrote:
> Samuel Benzaquen wrote:
> > Peter Collingbourne wrote:
> > > Please also test that extra stuff after the unlet query causes an error.
> > I'm sorry, but I don't know what extra stuff you are referring to.
> Sorry if I wasn't clear. I meant that if for example the query was something like "unlet x foo" we should reject it because of the extra input "foo" at the end.
Done.


http://reviews.llvm.org/D3383






More information about the cfe-commits mailing list