r206687 - Move ObjC Cocoa.h header test to Headers

Richard Smith richard at metafoo.co.uk
Sun Apr 20 17:50:37 PDT 2014


On Sat, Apr 19, 2014 at 12:07 PM, Alp Toker <alp at nuanti.com> wrote:

> Author: alp
> Date: Sat Apr 19 14:07:24 2014
> New Revision: 206687
>
> URL: http://llvm.org/viewvc/llvm-project?rev=206687&view=rev
> Log:
> Move ObjC Cocoa.h header test to Headers
>
> This tests for broad compatibility with platform SDK headers using the
> clang
> driver and so belongs alongside the other header ingtegration tests.
>

I agree that test/SemaObjC isn't the right place for this, but nor is
test/Headers (which contains tests for the compiler-supplied headers in
lib/Headers).

This seems like kind of a random and strange test to have at all, but if we
really want this, test/Misc might be a better place.

Added:
>     cfe/trunk/test/Headers/cocoa.m
>       - copied, changed from r206686, cfe/trunk/test/SemaObjC/cocoa.m
> Removed:
>     cfe/trunk/test/SemaObjC/cocoa.m
>
> Copied: cfe/trunk/test/Headers/cocoa.m (from r206686,
> cfe/trunk/test/SemaObjC/cocoa.m)
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/cocoa.m?p2=cfe/trunk/test/Headers/cocoa.m&p1=cfe/trunk/test/SemaObjC/cocoa.m&r1=206686&r2=206687&rev=206687&view=diff
>
> ==============================================================================
> --- cfe/trunk/test/SemaObjC/cocoa.m (original)
> +++ cfe/trunk/test/Headers/cocoa.m Sat Apr 19 14:07:24 2014
> @@ -1,4 +1,4 @@
> -// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats
> +// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats
>  #ifdef __APPLE__
>  #include <Cocoa/Cocoa.h>
>  #endif
>
> Removed: cfe/trunk/test/SemaObjC/cocoa.m
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/cocoa.m?rev=206686&view=auto
>
> ==============================================================================
> --- cfe/trunk/test/SemaObjC/cocoa.m (original)
> +++ cfe/trunk/test/SemaObjC/cocoa.m (removed)
> @@ -1,5 +0,0 @@
> -// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats
> -#ifdef __APPLE__
> -#include <Cocoa/Cocoa.h>
> -#endif
> -
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140420/b00c7831/attachment.html>


More information about the cfe-commits mailing list