[PATCH] MinGW toolchain

Ruben Van Boxem vanboxem.ruben at gmail.com
Sat Apr 19 12:11:48 PDT 2014


  @Martell: Currently there is no functional libc++, so it makes little sense in coding up directory logic if that might still change between then and now. But if you feel you can write something future-proof in this regard, I won't stop you.


================
Comment at: lib/Frontend/InitHeaderSearch.cpp:307-308
@@ -342,3 +306,4 @@
 
-  if ( os != llvm::Triple::RTEMS )
+  if ((os != llvm::Triple::RTEMS) &&
+     (!((os == llvm::Triple::Win32) && (triple.getEnvironment() == llvm::Triple::GNU))))
     AddPath("/usr/include", ExternCSystem, false);
----------------
Martell Malone wrote:
> This isn't exactly the best looking code.
> It gets the job done but I would prefer to have a better implementation of disabling that include.
> Suggestions would be much appreciated 
This was not part of my original patch. Are you sure it is necessary? Take a look at my additional changes in InitHeaderSearch.cpp (the last change in the file). I never had /usr/include appear when I tested my original patch for any configuration.

(for reference, my patch is located here: http://llvm.org/bugs/show_bug.cgi?id=18546)


http://reviews.llvm.org/D3420






More information about the cfe-commits mailing list