[PATCH] Follow-up to r206457 -- fix static adjustments for some subtle virtual inheritance cases

Timur Iskhodzhanov timurrrr at google.com
Fri Apr 18 08:17:18 PDT 2014

2014-04-18 1:38 GMT+04:00 Reid Kleckner <rnk at google.com>:
> ================
> Comment at: test/CodeGenCXX/microsoft-abi-vtables-virtual-inheritance.cpp:459
> @@ +458,3 @@
> +namespace Test12 {
> +struct X : B, A { };
> +
> ----------------
> Going forward, I'd really prefer it if our inheritance hierarchy tests could all be standalone.  See the microsoft-abi-vbtables.cpp test cases, where the contents of any namespace can be cut-and-paste into a standalone .cpp file and compiled.
> In this test, I have to go lookup ::A and ::B in the right namespace to figure out what kind of record this is going to be.  It's worth a few lines of duplicated test code to avoid that.

Like r206614?

More information about the cfe-commits mailing list