[PATCH][ARM64] Fix predefines and add plumbing for -mfpu=

[James Molloy]

Hi Tim,

Thanks for asking me to do that, I found a bug in so doing (hadn't conditionalised the NEON predefines).

I've now split the commit out into two, fixed the NetBSD copy-pasto and enabled test/Preprocessor/init.c for LE and BE.

OK to commit this time?

Cheers,

James

> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 16 April 2014 13:47
> To: James Molloy
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH][ARM64] Fix predefines and add plumbing for -mfpu=
> 
> Hi James,
> 
> Mostly looks OK, though it might be better off as a couple of commits:
> I can see combining predefines & BE, but NEON looks a bit peripheral.
> 
> +    case llvm::Triple::NetBSD:
> +      return new NetBSDTargetInfo<AArch64leTargetInfo>(Triple);
> 
> Shouldn't that be ARM64 for now? (& Big-endian case).
> 
> Also, isn't there some AArch64 predefine test you can hook into to
> make sure we actually are emitting the right ones? It looks like all
> of your test changes are just of the "-target-feature neon" kind.
> 
> Cheers.
> 
> Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM64-Fix-up-predefines-including-adding-big-endian-.patch
Type: application/octet-stream
Size: 7436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140416/57270a09/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ARM64-Allow-the-disabling-of-NEON-and-crypto-instruc.patch
Type: application/octet-stream
Size: 35763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140416/57270a09/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ARM64-Plumb-in-the-mfpu-flag.patch
Type: application/octet-stream
Size: 3885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140416/57270a09/attachment-0002.obj>