SV: [PATCH] don't diagnose -Wchar-subscript for safe char literal
Daniel Marjamäki
Daniel.Marjamaki at evidente.se
Wed Apr 16 07:10:13 PDT 2014
Thank you!
> This doesn't look like it's quite enough: if the index's type is Char_S, you should also check whether the value of the character literal is negative.
I added a testcase for array['\xFF'] also.
There is a array out of bounds message reported then.
Best regards,
Daniel Marjamäki
..................................................................................................................
Daniel Marjamäki
Senior Engineer
Evidente ES East AB
Warfvinges väg 34 SE-112 51 Stockholm Sweden
Mobile:
+46 (0)709 12 42 62
E-mail:
Daniel.Marjamaki at evidente.se
www.evidente.se
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 18389-2.diff
Type: text/x-patch
Size: 1263 bytes
Desc: 18389-2.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140416/c4737287/attachment.bin>
More information about the cfe-commits
mailing list