r206298 - Fix a comment to match the implementation

Alp Toker alp at nuanti.com
Tue Apr 15 11:01:28 PDT 2014


On 15/04/2014 18:40, Nico Weber wrote:
> Might as well just delete the comment, it only repeats the text in the 
> next lineā€¦

These self-explanatory comments have become pretty widespread in the 
frontend and I can't say I'm a fan either, especially when they're wrong.

Agree it seems reasonable to remove them unless they're quoting a spec 
or adding value in some other way. Want to take a shot at it?

Alp.



>
>
> On Tue, Apr 15, 2014 at 9:24 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>     Author: alp
>     Date: Tue Apr 15 11:24:50 2014
>     New Revision: 206298
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=206298&view=rev
>     Log:
>     Fix a comment to match the implementation
>
>     Modified:
>         cfe/trunk/lib/Sema/SemaDecl.cpp
>
>     Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
>     URL:
>     http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=206298&r1=206297&r2=206298&view=diff
>     ==============================================================================
>     --- cfe/trunk/lib/Sema/SemaDecl.cpp (original)
>     +++ cfe/trunk/lib/Sema/SemaDecl.cpp Tue Apr 15 11:24:50 2014
>     @@ -8623,7 +8623,7 @@ void Sema::ActOnInitializerError(Decl *D
>          return;
>        }
>
>     -  // Require an abstract type.
>     +  // Require a non-abstract type.
>        if (RequireNonAbstractType(VD->getLocation(), Ty,
>     diag::err_abstract_type_in_decl,
>                                   AbstractVariableType)) {
>
>
>     _______________________________________________
>     cfe-commits mailing list
>     cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list