[Patch] Missed evaluation in "type" parameter of va_arg

[Rahul Jain]

Thanks Richard for helping out! Very much appreciated!

Also thanks to Rahul Singh, who originally worked out the fix.


Thanks,
Rahul


On Tue, Apr 15, 2014 at 5:24 AM, Richard Smith <richard at metafoo.co.uk>wrote:

> Slightly tweaked and committed as r206223. Thanks!
>
>
> On Mon, Apr 14, 2014 at 7:55 AM, Rahul Jain <1989.rahuljain at gmail.com>wrote:
>
>>
>> Hi Richard,
>>
>> Thanks for your valuable input.
>> Updated the patch accordingly.
>>
>> Please if you could commit the same for me.
>>
>> Thanks,
>> Rahul
>>
>>
>> On Mon, Apr 14, 2014 at 5:08 AM, Richard Smith <richard at metafoo.co.uk>wrote:
>>
>>> Please add a triple to your test (right now, it'd fail on targets where
>>> 'int' isn't i32). Otherwise, LGTM.
>>>
>>>
>>> On Mon, Apr 7, 2014 at 11:26 AM, Rahul Jain <1989.rahuljain at gmail.com>wrote:
>>>
>>>>
>>>> Hi Dmitri,
>>>>
>>>> Thanks for replying.
>>>>
>>>> Updated patch with test case.
>>>> Please help review the same.
>>>>
>>>> Thanks,
>>>> Rahul
>>>>
>>>>
>>>> On Fri, Apr 4, 2014 at 8:46 PM, Dmitri Gribenko <gribozavr at gmail.com>wrote:
>>>>
>>>>> On Wed, Apr 2, 2014 at 6:55 AM, Rahul Jain <1989.rahuljain at gmail.com>
>>>>> wrote:
>>>>> > Gentle ping!
>>>>> >
>>>>> > Please if someone could help review this small patch!
>>>>>
>>>>> Hello Rahul,
>>>>>
>>>>> This patch needs a testcase.
>>>>>
>>>>> Dmitri
>>>>>
>>>>> --
>>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>>>>>
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140415/a9117338/attachment.html>