[LLVMdev] 3.4.1 Release Plans

Tom Stellard tom at stellard.net
Thu Apr 10 13:26:29 PDT 2014


On Thu, Apr 10, 2014 at 05:15:50AM +0800, Jiangning Liu wrote:
> Hi Tom,
> 
> I'm extremely appreciative of your help on back porting those patches!
> 
> > > 198937 Make sure -use-init-array has intended effect on all AArch64 ELF
> > > targets, not just linux.
> >
> > I wasn't able to merge this commit, because it broke ABI compatibility of
> > the LLVM library shared object.  This is because it removes the function
> > llvm::AArch64LinuxTargetObjectFileInitialize ( llvm::MCContext&,
> >                                                llvm:TargetMachine const&);
> >
> > Does the clang commit mentioned above require this LLVM change?  I
> > wasn't sure, so I didn't merge it.  If you can come up with a version of
> > this patch that doesn't break the ABI, then I can merge it.  Let me know
> > what you want to do.
> >
> Yes, this patch is required by the clang commit. The patch is to change the
> name only, so can you simply keep two methods before and after the
> replacement and make them to have the same content, I think it should work
> and will not break ABI.
> 

I'm having trouble porting the clang commit r198940.  It causes two
tests to fail:

Clang :: Driver/bindings.c
Clang :: Driver/unknown-gcc-arch.c

Would you be able to prepare a working patch that I can apply to the
stable branch?

Thanks,
Tom



More information about the cfe-commits mailing list