[PATCH] Extend the check to detect patterns like 'ptr.get() == nullptr'

[Alexander Kornienko]

  Another couple of notes, otherwise looks good!


================
Comment at: test/clang-tidy/check_clang_tidy_output.sh:10
@@ +9,3 @@
+
+$(dirname $0)/make_compile_commands_json.sh ${INPUT_FILE} ${TEMPORARY_DIR}
+clang-tidy --checks=${CHECK_TO_RUN} ${INPUT_FILE} -p ${TEMPORARY_DIR} |
----------------
Why not use static compilation database instead of generating compile_commands.json?

  clang-tidy -checks=${CHECK_TO_RUN} ${INPUT_FILE} -- -std=c++11 | FileCheck ${INPUT_FILE}

================
Comment at: test/clang-tidy/check_clang_tidy_output.sh:12
@@ +11,2 @@
+clang-tidy --checks=${CHECK_TO_RUN} ${INPUT_FILE} -p ${TEMPORARY_DIR} |
+FileCheck ${INPUT_FILE}
----------------
This being on a line of its own without indentation looks confusing. Could you put the whole pipeline on a single line or use indentation here (and put the pipe on the next line)?

  clang-tidy ... \
    | FileCheck ...


http://reviews.llvm.org/D3294

BRANCH
  get_==

ARCANIST PROJECT
  clang-tools-extra