r205761 - clang-format: Correctly understand arrays of pointers.
Daniel Jasper
djasper at google.com
Tue Apr 8 06:07:41 PDT 2014
Author: djasper
Date: Tue Apr 8 08:07:41 2014
New Revision: 205761
URL: http://llvm.org/viewvc/llvm-project?rev=205761&view=rev
Log:
clang-format: Correctly understand arrays of pointers.
Before:
A<int * []> a;
After:
A<int *[]> a;
This fixes llvm.org/PR19360.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=205761&r1=205760&r2=205761&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Tue Apr 8 08:07:41 2014
@@ -245,7 +245,7 @@ private:
StartsObjCMethodExpr = false;
Left->Type = TT_Unknown;
}
- if (StartsObjCMethodExpr) {
+ if (StartsObjCMethodExpr && CurrentToken->Previous != Left) {
CurrentToken->Type = TT_ObjCMethodExpr;
// determineStarAmpUsage() thinks that '*' '[' is allocating an
// array of pointers, but if '[' starts a selector then '*' is a
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=205761&r1=205760&r2=205761&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Tue Apr 8 08:07:41 2014
@@ -4473,6 +4473,7 @@ TEST_F(FormatTest, UnderstandsUsesOfStar
verifyIndependentOfContext("A<int *> a;");
verifyIndependentOfContext("A<int **> a;");
verifyIndependentOfContext("A<int *, int *> a;");
+ verifyIndependentOfContext("A<int *[]> a;");
verifyIndependentOfContext(
"const char *const p = reinterpret_cast<const char *const>(q);");
verifyIndependentOfContext("A<int **, int **> a;");
More information about the cfe-commits
mailing list