r205715 - Fix clang-tidy warning (argument comments don't match parameter names).

Benjamin Kramer benny.kra at gmail.com
Mon Apr 7 08:58:52 PDT 2014


> Am 07 Apr 2014 um 16:16 schrieb Richard Smith <richard-llvm at metafoo.co.uk>:
> 
> Author: rsmith
> Date: Mon Apr  7 10:16:58 2014
> New Revision: 205715
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=205715&view=rev
> Log:
> Fix clang-tidy warning (argument comments don't match parameter names).

Awesome!

- Ben

> 
> Modified:
>    cfe/trunk/include/clang/Sema/DeclSpec.h
>    cfe/trunk/lib/Sema/SemaDecl.cpp
> 
> Modified: cfe/trunk/include/clang/Sema/DeclSpec.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/DeclSpec.h?rev=205715&r1=205714&r2=205715&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Sema/DeclSpec.h (original)
> +++ cfe/trunk/include/clang/Sema/DeclSpec.h Mon Apr  7 10:16:58 2014
> @@ -1414,8 +1414,8 @@ struct DeclaratorChunk {
> 
>   /// DeclaratorChunk::getFunction - Return a DeclaratorChunk for a function.
>   /// "TheDeclarator" is the declarator that this will be added to.
> -  static DeclaratorChunk getFunction(bool hasProto,
> -                                     bool isAmbiguous,
> +  static DeclaratorChunk getFunction(bool HasProto,
> +                                     bool IsAmbiguous,
>                                      SourceLocation LParenLoc,
>                                      ParamInfo *Params, unsigned NumParams,
>                                      SourceLocation EllipsisLoc,
> 
> Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=205715&r1=205714&r2=205715&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaDecl.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaDecl.cpp Mon Apr  7 10:16:58 2014
> @@ -10088,9 +10088,9 @@ NamedDecl *Sema::ImplicitlyDefineFunctio
>   Declarator D(DS, Declarator::BlockContext);
>   D.AddTypeInfo(DeclaratorChunk::getFunction(/*HasProto=*/false,
>                                              /*IsAmbiguous=*/false,
> -                                             /*RParenLoc=*/NoLoc,
> -                                             /*ArgInfo=*/0,
> -                                             /*NumArgs=*/0,
> +                                             /*LParenLoc=*/NoLoc,
> +                                             /*Params=*/0,
> +                                             /*NumParams=*/0,
>                                              /*EllipsisLoc=*/NoLoc,
>                                              /*RParenLoc=*/NoLoc,
>                                              /*TypeQuals=*/0,
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list