[PATCH] Add support for optimization reports.

Diego Novillo dnovillo at google.com
Wed Apr 2 19:03:48 PDT 2014


  Address review feedback

    - When emitting an optimization report diagnostic, the lack of debug
      information sometimes causes internal failures. If debug information is not
      present, the diagnostic uses "<unknown>:0:0" as the location string.

    - Rename OptimizationReport to OptimizationRemark.

    - Only enable line table generation if no debug information had been
      requested.

    - Add a default remark diagnostic class to enable -Rpass diagnostics.

    - Change the diagnostic group for BackendOptimizationRemark to "pass".

    - Add DiagnosticIDs::isRemark(). Use it in printDiagnosticOptions to
      print "-R" instead of "-W" in the diagnostic message.

    - Re-word the help text for -Rpass=.

    - In BackendConsumer::OptimizationRemarkHandler, get a SourceLocation
      object out of the file name, line and column number. Use that location
      in the call to Diags.Report().

    - If -Rpass= is used, also enable column information by adding
      -dwarf-column-info to the backend command line.

    - Add test for -Rpass=. Document OptimizationRemarkHandler.

Hi qcolombet, rsmith,

http://llvm-reviews.chandlerc.com/D3226

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D3226?vs=8246&id=8322#toc

Files:
  include/clang/Basic/Diagnostic.td
  include/clang/Basic/DiagnosticDriverKinds.td
  include/clang/Basic/DiagnosticFrontendKinds.td
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticIDs.h
  include/clang/Driver/Options.td
  include/clang/Frontend/CodeGenOptions.h
  lib/Basic/DiagnosticIDs.cpp
  lib/CodeGen/CodeGenAction.cpp
  lib/Driver/Tools.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/TextDiagnosticPrinter.cpp
  test/Frontend/optimization-remark.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3226.3.patch
Type: text/x-patch
Size: 11270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140402/6447bb44/attachment.bin>


More information about the cfe-commits mailing list