[PATCH] Driver: add target definition for Windows on ARM

[Renato Golin]

  Hi Saleen,

  Apart from the comments, I don't think there's anything wrong with this, but as you commented extensively, it needs some love on the options (WindowsCE, arch variants, features, etc). Though, it should be good to bootstrap Windows support on ARM, and we can follow from here.

  cheers,
  --renato


================
Comment at: lib/Basic/Targets.cpp:3719
@@ +3718,3 @@
+      T.getArchName().substr(Offset).getAsInteger(10, Version);
+      assert(Version >= 7);
+      return true;
----------------
Isn't an assert a bit too drastic? Maybe we should catch this somewhere else with an error message?

================
Comment at: lib/Basic/Targets.cpp:4428
@@ +4427,3 @@
+    // 31: VFPv3 40: VFPv4
+    Builder.defineMacro("_M_ARM_FP", "31");
+  }
----------------
You default to cortex-a9 and VFPv4 at the same time, but A9 is VFPv3. You should either default to v3 or require A15/A7+.


http://llvm-reviews.chandlerc.com/D3241