[PATCH] preview patch for fixit for finding modules needing import/inclusion
John Thompson
john.thompson.jtsoftware at gmail.com
Tue Apr 1 11:11:06 PDT 2014
I added a BuildingModule flag to ModuleLoader so I could avoid doing the correctTypo modules import fixit or global module index rebuild when a module is being built.
I merged the prior need import error message into a single warning.
I hack the test/Modules tests to accomodate the new error, and to disable the modules import fixit for tests that trigger an index rebuild involving the test/Modules/module.map file, as some modules have build errors that get triggered.
I didn't do anything with respect to the issue of not displaying error messages during a module build, leaving it for a separate fix.
Is this ready to check in?
Thanks.
-John
Hi doug.gregor, rsmith,
http://llvm-reviews.chandlerc.com/D2671
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D2671?vs=8146&id=8275#toc
Files:
test/Modules/cxx-templates.cpp
test/Modules/subframeworks.m
test/Modules/lookup.cpp
test/Modules/objc-categories.m
test/Modules/auto-module-import.m
test/Modules/undefined-type-fixit1.cpp
test/Modules/wildcard-submodule-exports.cpp
test/Modules/module-private.cpp
test/Modules/decldef.m
test/Modules/redecl-namespaces.mm
test/Modules/normal-module-map.cpp
test/Modules/extern_c.cpp
test/Modules/cxx-inline-namespace.cpp
test/Modules/template-specialization-visibility.cpp
test/Modules/decldef.mm
test/Modules/Inputs/undefined-type-fixit/public2sub.h
test/Modules/Inputs/undefined-type-fixit/module.map
test/Modules/Inputs/undefined-type-fixit/public1.h
test/Modules/Inputs/undefined-type-fixit/public2.h
test/Modules/cxx-linkage-cache.cpp
test/Modules/submodules.cpp
include/clang/Frontend/CompilerInstance.h
include/clang/Frontend/ASTUnit.h
include/clang/Basic/LangOptions.def
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
include/clang/Lex/ModuleLoader.h
include/clang/Lex/HeaderSearch.h
include/clang/Driver/Options.td
include/clang/Serialization/ASTReader.h
include/clang/Serialization/GlobalModuleIndex.h
unittests/Basic/SourceManagerTest.cpp
unittests/Lex/LexerTest.cpp
unittests/Lex/PPCallbacksTest.cpp
unittests/Lex/PPConditionalDirectiveRecordTest.cpp
unittests/Lex/CMakeLists.txt
unittests/Lex/Makefile
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Sema/SemaDeclObjC.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
lib/Sema/SemaLookup.cpp
lib/Lex/HeaderSearch.cpp
lib/Serialization/GlobalModuleIndex.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2671.3.patch
Type: text/x-patch
Size: 52609 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140401/9a59446f/attachment.bin>
More information about the cfe-commits
mailing list