[LLVMdev] 3.4.1 Release Plans

[Renato Golin]

Hi Jiangning,

Thank you very much for doing all the hard work of integrating the
patches and testing it beforehand, it really helps the back-porting!


On 1 April 2014 09:25, Jiangning Liu <liujiangning1 at gmail.com> wrote:
> I know the patch list is little bit longer, we have the following reasons,
> 1) Last year, when branch 3.4 was created, actually we didn't really have
> time to complete all AArch64 neon work. So branch 3.4 is actually at the
> middle stage of aarch64 neon implementation. Now the patches I'm requesting
> intends to give a complete AArch64 NEON feature.

I'd be less comfortable with this change than the others, since it
introduces new functionality (and may introduce incompatibility with
previous behaviour), but I'll let Tom decide.

One reason in favour of having it is that you have already tested it
extensively. But that doesn't remove the risk of external projects
relying on 3.4 to break unexpectedly.


> 2) There are several critical bug fixes solving compiler crash issue, and
> our end-user really want them to be fixed in new release, and end-user can't
> wait until release 3.5.

Those should all go in.


> 3) A lot of patches are interleaved and have dependence one another, so it's
> easy to introduce bug if do cherry picking only for some of them.

If that's related to NEON+bugfixes, than it's another reason to have
the NEON part in. If not, at least is a reason to have all bugfixes
in.

cheers,
--renato