r205223 - MS ABI: Document the '\xc1' to '\xda' manglings

[Richard Smith]

On Mon, Mar 31, 2014 at 10:09 AM, David Majnemer
<david.majnemer at gmail.com>wrote:

> Author: majnemer
> Date: Mon Mar 31 12:09:09 2014
> New Revision: 205223
>
> URL: http://llvm.org/viewvc/llvm-project?rev=205223&view=rev
> Log:
> MS ABI: Document the '\xc1' to '\xda' manglings
>
> No functionality change.
>
> Modified:
>     cfe/trunk/lib/AST/MicrosoftMangle.cpp
>
> Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=205223&r1=205222&r2=205223&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original)
> +++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Mon Mar 31 12:09:09 2014
> @@ -2419,6 +2419,7 @@ void MicrosoftMangleContextImpl::mangleS
>        Mangler.getStream() << Byte;
>      } else if ((Byte >= '\xe1' && Byte <= '\xfa') ||
>                 (Byte >= '\xc1' && Byte <= '\xda')) {
> +      // The delta between '\xe1' and '\xc1' is the same as 'a' to 'A'.
>        Mangler.getStream() << '?' << static_cast<char>('A' + (Byte -
> '\xc1'));
>

I think this would be more obvious as:

if (clang::isLetter(Byte ^ 0x80))
  Mangler.getStream() << '?' << static_cast<char>(Byte ^ 0x80);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140331/d0e62272/attachment.html>