[PATCH] Add support for optimization reports.

Eric Christopher echristo at gmail.com
Mon Mar 31 12:04:37 PDT 2014


  Couple of comments here:

  a) The WRPass thing is awkward. No, I don't know how to fix it offhand.

  The rest are inline.

  -eric


================
Comment at: lib/Frontend/CompilerInvocation.cpp:536
@@ +535,3 @@
+      // enable line table generation.
+      Opts.setDebugInfo(CodeGenOptions::DebugLineTablesOnly);
+    }
----------------
I think this will just set line tables only as opposed to the greater of line-tables-only and whatever we've currently got.

================
Comment at: lib/Driver/Tools.cpp:3296
@@ -3295,1 +3295,3 @@
 
+  if (Arg *A = Args.getLastArg(options::OPT_Rpass_EQ)) {
+    A->render(Args, CmdArgs);
----------------
Extra braces?

================
Comment at: lib/CodeGen/CodeGenAction.cpp:390
@@ +389,3 @@
+                               diag::Mapping::MAP_REMARK, Loc);
+    // FIXME: There should be a way of transferring the DILocation
+    // content into a SourceLocation. We are building the location string
----------------
I'm not sure we can get back to the same encoding, but it could be useful if we wanted to map accordingly.

Also did you want the discriminator here?


http://llvm-reviews.chandlerc.com/D3226



More information about the cfe-commits mailing list