r205158 - RTTI: refactor the uniqueness question into CGCXXABI.

[Tim Northover]

Hi Rafael,

On 31 Mar 2014, at 16:44, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>   // If we're supposed to demote the visibility, be sure to set a flag
>>   // to use a string comparison for type_info comparisons.
>> -  UniqueRTTIKind uniqueRTTI = classifyUniqueRTTI(CGM, Ty, Linkage);
>> -  if (uniqueRTTI != UniqueRTTI) {
>> +  CGCXXABI::RTTIUniquenessKind RTTIUniqueness =
>> +      CGM.getCXXABI().classifyRTTIUniqueness(Ty, Linkage);
>> +  if (RTTIUniqueness != CGCXXABI::RUK_Unique) {
> 
> 
> This means that the flag is always set for arm64, right? If it is
> always set, why is the flag needed?

I don't think I follow. It's always RUK_Unique for platforms other than iOS ARM64 (currently), but it can be different on ARM64.

Or did you mean something else?

Cheers.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140331/c47de44b/attachment.sig>