[PATCH] Sema: Check dll attributes on redeclarations

[Reid Kleckner]

lgtm


> --- a/include/clang/Basic/DiagnosticSemaKinds.td
> +++ b/include/clang/Basic/DiagnosticSemaKinds.td
> @@ -2074,6 +2074,8 @@ def err_attribute_selectany_non_extern_data : Error<
>  def warn_attribute_invalid_on_definition : Warning<
>    "'%0' attribute cannot be specified on a definition">,
>    InGroup<IgnoredAttributes>;
> +def err_attribute_dll_redeclaration : Error<
> +  "%q0 redeclared with different dll attributes">;


Should we be more specific here?  Something like:
redeclaration %0 adds attribute %1 which was missing the previous
declaration



On Wed, Mar 26, 2014 at 9:12 AM, Nico Rieck <nico.rieck at gmail.com> wrote:

> This patch implements semantic handling of redeclarations with dllimport
> or dllexport attributes. Both attributes must appear on the first
> declaration, and dllimport must appear on every redeclaration.
>
> -Nico
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140330/ed6e794c/attachment.html>