[PATCH] OpenCL 1.2 disallow kernel parameters with private address space

David Tweed david.tweed at gmail.com
Thu Mar 27 04:47:04 PDT 2014


Hi,

This looks patch looks LGTM, but being hyper-pedantic I'd suggest
saying in the commit message that it "enforces the restriction that a
kernel parameter cannot be declared as a pointer to the private
address space (as clarified in OpenCL 1.2)" (since clang isn't really
doing any discrimation of precise OpenCL standard versions anywhere in
the code.)

On Thu, Mar 27, 2014 at 10:55 AM, Fraser Cormack <fraser at codeplay.com> wrote:
> Hi,
>
> This patch enforces the restriction in OpenCL 1.2 that a kernel parameter
> cannot be declared as a pointer to the private address space. See OpenCL 1.2
> spec section 6.9a, first item.
> Cheers,
> Fraser
>
> --
> Fraser Cormack
> Compiler Developer
> Codeplay Software Ltd
> 45 York Place, Edinburgh, EH1 3HP
> Tel: 0131 466 0503
> Fax: 0131 557 6600
> Website: http://www.codeplay.com
> Twitter: https://twitter.com/codeplaysoft
>
> This email and any attachments may contain confidential and /or privileged
> information and  is for use  by the addressee only. If you are not the
> intended recipient, please notify Codeplay Software Ltd immediately and
> delete the message from your computer. You may not copy or forward it,or use
> or disclose its contents to any other person. Any views or other information
> in this message which do not relate to our business are not authorized by
> Codeplay software Ltd, nor does this message form part of any contract
> unless so stated.
> As internet communications are capable of data corruption Codeplay Software
> Ltd does not accept any responsibility for any changes made to this message
> after it was sent. Please note that Codeplay Software Ltd does not accept
> any liability or responsibility for viruses and it is your responsibility to
> scan any attachments.
> Company registered in England and Wales, number: 04567874
> Registered office: 81 Linkfield Street, Redhill RH1 6BY
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
cheers, dave tweed__________________________
high-performance computing and machine vision expert: david.tweed at gmail.com
"while having code so boring anyone can maintain it, use Python." --
attempted insult seen on slashdot



More information about the cfe-commits mailing list