[PATCH] [OPENMP] OMPExecutableDirective re-factoring

hfinkel at anl.gov hfinkel at anl.gov
Thu Mar 27 01:46:26 PDT 2014


  Can you please explain why you are making this change? It is not immediately clear to me (excluding formatting fixes) why the proposed code is better.


================
Comment at: include/clang/AST/StmtOpenMP.h:216
@@ +215,3 @@
+                   unsigned CollapsedNum, unsigned NumClauses)
+      : OMPExecutableDirective(this, OMPSimdDirectiveClass, OMPD_simd, StartLoc,
+                               EndLoc, NumClauses, 1),
----------------
Please commit the whitespace/formatting changes in this file separately.


http://llvm-reviews.chandlerc.com/D2977



More information about the cfe-commits mailing list