r204569 - Cleanup dead assignments reported by scan-build

[Arnaud Allard de Grandmaison]

Thanks for finishing the cleanup !


On Mon, Mar 24, 2014 at 12:15 PM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> FYI
> lib/CodeGen/CGBuiltin.cpp:3136:12: warning: variable 'TblPos' set but not
> used [-Wunused-but-set-variable]
> [detected by gcc 4.8.2]
>
> Fixed in r204599.
>
>
> 2014-03-24 0:28 GMT+04:00 Arnaud A. de Grandmaison <arnaud.adegm at gmail.com
> >:
>
> Author: aadg
>> Date: Sun Mar 23 15:28:07 2014
>> New Revision: 204569
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=204569&view=rev
>> Log:
>> Cleanup dead assignments reported by scan-build
>>
>> Modified:
>>     cfe/trunk/lib/CodeGen/CGBuiltin.cpp
>>     cfe/trunk/lib/Parse/ParseObjc.cpp
>>     cfe/trunk/lib/Sema/SemaExprMember.cpp
>>
>> Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=204569&r1=204568&r2=204569&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Sun Mar 23 15:28:07 2014
>> @@ -3120,9 +3120,6 @@ static Value *packTBLDVectorList(CodeGen
>>                                                       ZeroTbl, SV, Name));
>>    }
>>
>> -  TblTy = llvm::VectorType::get(TblTy->getElementType(),
>> -                                2*TblTy->getNumElements());
>> -
>>    Function *TblF;
>>    TblOps.push_back(IndexOp);
>>    TblF = CGF.CGM.getIntrinsic(IntID, ResTy);
>> @@ -3190,7 +3187,6 @@ static Value *EmitAArch64TblBuiltinExpr(
>>      Ops.push_back(CGF.EmitScalarExpr(E->getArg(i)));
>>    }
>>
>> -  Arg = E->getArg(TblPos);
>>    unsigned nElts = VTy->getNumElements();
>>
>>    // AArch64 scalar builtins are not overloaded, they do not have an
>> extra
>>
>> Modified: cfe/trunk/lib/Parse/ParseObjc.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseObjc.cpp?rev=204569&r1=204568&r2=204569&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Parse/ParseObjc.cpp (original)
>> +++ cfe/trunk/lib/Parse/ParseObjc.cpp Sun Mar 23 15:28:07 2014
>> @@ -2933,11 +2933,11 @@ void Parser::ParseLexedObjCMethodDefs(Le
>>    else
>>      Actions.ActOnStartOfFunctionDef(getCurScope(), MCDecl);
>>    if (Tok.is(tok::kw_try))
>> -    MCDecl = ParseFunctionTryBlock(MCDecl, BodyScope);
>> +    ParseFunctionTryBlock(MCDecl, BodyScope);
>>    else {
>>      if (Tok.is(tok::colon))
>>        ParseConstructorInitializer(MCDecl);
>> -    MCDecl = ParseFunctionStatementBody(MCDecl, BodyScope);
>> +    ParseFunctionStatementBody(MCDecl, BodyScope);
>>    }
>>
>>    if (Tok.getLocation() != OrigLoc) {
>>
>> Modified: cfe/trunk/lib/Sema/SemaExprMember.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprMember.cpp?rev=204569&r1=204568&r2=204569&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaExprMember.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaExprMember.cpp Sun Mar 23 15:28:07 2014
>> @@ -805,8 +805,6 @@ Sema::BuildAnonymousStructUnionMemberRef
>>      if (!result)
>>        return ExprError();
>>
>> -    baseObjectIsPointer = false;
>> -
>>      // FIXME: check qualified member access
>>    }
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140324/ce485e88/attachment.html>