r204261 - Add a new spelling for module map files 'module.modulemap'

Ben Langmuir blangmuir at apple.com
Thu Mar 20 07:47:14 PDT 2014


Thanks for letting me know.  Looks like Aaron Ballman already fixed this in r204345.

Be

On Mar 20, 2014, at 6:11 AM, Timur Iskhodzhanov <timurrrr at google.com> wrote:

> 
> 2014-03-20 0:23 GMT+04:00 Ben Langmuir <blangmuir at apple.com>:
>  bool HeaderSearch::loadModuleMapFile(const FileEntry *File, bool IsSystem) {
> +  switch (loadModuleMapFileImpl(File, IsSystem)) {
> +  case LMM_AlreadyLoaded:
> +  case LMM_NewlyLoaded:
> +    return false;
> +  case LMM_NoDirectory:
> +  case LMM_InvalidModuleMap:
> +    return true;
> +  }
> +}
> 
> FYI
> gcc-4.8.2 doesn't like it:
> ../tools/clang/lib/Lex/HeaderSearch.cpp: In member function ‘bool clang::HeaderSearch::loadModuleMapFile(const clang::FileEntry*, bool)’:
> ../tools/clang/lib/Lex/HeaderSearch.cpp:1159:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140320/17c37efc/attachment.html>


More information about the cfe-commits mailing list