[PATCH] [msan] -fsanitize-memory-track-origins=[level] flag and docs.

Alexey Samsonov samsonov at google.com
Thu Mar 20 02:33:19 PDT 2014



================
Comment at: test/Driver/fsanitize.c:78
@@ -77,3 +77,3 @@
 // RUN: %clang -target x86_64-linux-gnu -fsanitize-memory-track-origins -pie %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ONLY-TRACK-ORIGINS
-// CHECK-ONLY-TRACK-ORIGINS: warning: argument unused during compilation: '-fsanitize-memory-track-origins'
+// CHECK-ONLY-TRACK-ORIGINS: warning: argument unused during compilation: '-fsanitize-memory-track-origins=1'
 
----------------
Evgeniy Stepanov wrote:
> Alexey Samsonov wrote:
> > Evgeniy Stepanov wrote:
> > > Alexey Samsonov wrote:
> > > > This is confusing. We should try to print the flag the user has provided in command line.
> > > That's how this Alias thing works...
> > > We can stop using it, of course, and check all 3 flags manually.
> > If we can silently drop support for -fno-sanitize-memory-track-origins, I think it's fine to check two flags manually.
> There must be an -fno- option for every -f option.
> 
What a pity. Can we print a deprecated message for these flags then? :)
We do so for flags like -f(no-)address-sanitizer. Which reminds me we should probably delete them for good! :)


http://llvm-reviews.chandlerc.com/D3118



More information about the cfe-commits mailing list